[
https://issues.apache.org/jira/browse/IMPALA-13668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930232#comment-17930232
]
ASF subversion and git services commented on IMPALA-13668:
----------------------------------------------------------
Commit 1c764c6f524a7593078125b3cba16a7948c1bf3b in impala's branch
refs/heads/branch-4.5.0 from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1c764c6f5 ]
IMPALA-13761: Fix test_coord_only_pool_exec_groups
IMPALA-13201 adds test_coord_only_pool_exec_groups. This test failed in
TestAdmissionControllerWithACService due to unaccounted AdmissionD as
the extra statestore subscriber. This patch fix the issue by using
expected_subscribers and expected_num_impalads argument for
CustomClusterTestSuite._start_impala_cluster() and relies on wait
mechanism inside it.
This patch also does some adjustments:
1. Tweak __run_assert_systables_query to not use
execute_query_using_vector from IMPALA-13694.
2. Remove default_impala_client() call, first added by IMPALA-13668, and
use self.client instead.
3. Fixed minor flake8 issue at test_coord_only_pool_happy_path.
These make it possible to backport IMPALA-13201 and IMPALA-13761
together to older release/maintenance branch.
Testing:
Run the test with this command:
impala-py.test --exploration=exhaustive \
-k test_coord_only_pool custom_cluster/test_admission_controller.py
Change-Id: I00b83e706aca3325890736133b2d1dcf735b19df
Reviewed-on: http://gerrit.cloudera.org:8080/22486
Reviewed-by: Peter Rozsa <[email protected]>
Reviewed-by: Jason Fehr <[email protected]>
Tested-by: Jason Fehr <[email protected]>
> Add default_test_protocol parameter to conftest.py
> --------------------------------------------------
>
> Key: IMPALA-13668
> URL: https://issues.apache.org/jira/browse/IMPALA-13668
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 4.5.0
>
>
> ImpalaTestSuite.client is always initialized as beeswax client. And many
> tests use it directly rather than going through helper method such as
> execute_query().
> https://github.com/apache/impala/blob/5f4321373a3404867e170f7381db04a843aa7310/tests/common/impala_test_suite.py#L354
> We should add default_test_protocol parameter to conftest.py so that we can
> change it to hs2 or hs2-http client. This will help us check which tests is
> already compatible with hs2 and which one still need adjustment.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
