[
https://issues.apache.org/jira/browse/IMPALA-14838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18087107#comment-18087107
]
ASF subversion and git services commented on IMPALA-14838:
----------------------------------------------------------
Commit b0f3623fcb7129d39c5b246508975b5ed7eea3f7 in impala's branch
refs/heads/master from Aleksandr Efimov
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b0f3623fc ]
IMPALA-15078: Fix TSAN race in data-stream test
The IMPALA-14838 regression test updated
FLAGS_datastream_sender_timeout_ms after DataStreamTest::SetUp() had
already started KrpcDataStreamMgr's maintenance thread. TSAN can report
a race because Maintenance() reads the same flag concurrently.
The longer early-sender timeout is unnecessary here because the test
creates the receiver before starting the sender. Remove the flag update
from the test body so the maintenance thread has no concurrent gflag
writer.
Testing:
git diff --check
Assisted-by: OpenAI Codex
Change-Id: Ied81ad4660e8fb69a443f2c74c6fafc6c99c0c18
Reviewed-on: http://gerrit.cloudera.org:8080/24414
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> TotalHasDeferredRPCsTime is not set if deferred_rpcs_ is never empty
> ---------------------------------------------------------------------
>
> Key: IMPALA-14838
> URL: https://issues.apache.org/jira/browse/IMPALA-14838
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Csaba Ringhofer
> Assignee: Aleksandr Efimov
> Priority: Major
> Labels: ramp-up
> Fix For: Impala 5.0.0
>
>
> Saw these conflicting counters in a cancelled profile:
> - TotalHasDeferredRPCsTime: 0.000ns
> - TotalRPCsDeferred: 1.36K (1364)
> The issue is that TotalHasDeferredRPCsTime is only increased when the queue
> gets empty so will be 0 if the query is cancelled while the queue was never
> depleted:
> https://github.com/apache/impala/blob/ef2d50e68987ccbf713122b8f301709a874c5121/be/src/runtime/krpc-data-stream-recvr.cc#L339
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
