[
https://issues.apache.org/jira/browse/IMPALA-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18096908#comment-18096908
]
ASF subversion and git services commented on IMPALA-15096:
----------------------------------------------------------
Commit b9ac487b7e3d9033420e83f1677cac1c21d676cc in impala's branch
refs/heads/master from Aleksandr Efimov
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b9ac487b7 ]
IMPALA-15096: Do not escape raw text profiles
Text profiles downloaded from the WebUI are served through raw_text.tmpl
after setting Webserver::ENABLE_RAW_HTML_KEY. The template still used
escaped Mustache substitution, so profile text with characters such as
'<', '>', and apostrophes was downloaded with HTML entities.
Render contents unescaped only when __raw__ is present. This preserves
escaped output for non-raw users of the template. Add tests for raw and
non-raw rendering.
Update WebUI profile download tests, including LDAP coverage, to expect
raw text from /query_profile_plain_text.
Testing:
- git diff --check asf-gerrit/master..HEAD
- python3 -m py_compile tests/webserver/test_web_pages.py
tests/custom_cluster/test_web_pages.py
- python3 bin/jenkins/critique-gerrit-review.py --dryrun
- Verified html.unescape(rf_profile_web.txt) matches rf_profile.txt
using the IMPALA-15096 attachments
- Ran be/build/latest/util/webserver-test with a gtest filter for
RawTextTemplateDoesNotEscapeRawContents and
RawTextTemplateEscapesNonRawContents
Assisted-by: GPT-5 (Codex)
Change-Id: I07965b7c550af6d136e4c343da84f77374e236ed
Reviewed-on: http://gerrit.cloudera.org:8080/24453
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Text profiles downloaded from WebUI have HTML entities
> ------------------------------------------------------
>
> Key: IMPALA-15096
> URL: https://issues.apache.org/jira/browse/IMPALA-15096
> Project: IMPALA
> Issue Type: Bug
> Reporter: Quanlong Huang
> Assignee: Aleksandr Efimov
> Priority: Major
> Attachments: rf_profile.txt, rf_profile_web.txt
>
>
> Text profiles downloaded from WebUI have HTML entities like "&apos;",
> "&lt;", "&gt;". These impact readability. We should convert them to
> the actual characters in the downloaded profile.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
