[
https://issues.apache.org/jira/browse/ARTEMIS-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908115#comment-14908115
]
ASF GitHub Bot commented on ARTEMIS-228:
----------------------------------------
GitHub user jscheid opened a pull request:
https://github.com/apache/activemq-artemis/pull/176
ARTEMIS-228 accept binary WebSocket frames
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/waysact/activemq-artemis
ARTEMIS-228-binary-websocket-frames
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
commit 84f14453bd75d0caa71e8713bf4e99a54e3015e9
Author: Julian Scheid <[email protected]>
Date: 2015-09-25T12:10:20Z
ARTEMIS-228 accept binary WebSocket frames
----
> Accept BinaryWebSocketFrame in STOMP WebSocketServerHandler
> -----------------------------------------------------------
>
> Key: ARTEMIS-228
> URL: https://issues.apache.org/jira/browse/ARTEMIS-228
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Julian Scheid
> Priority: Minor
>
> {{WebSocketServerHandler}} currently only accepts {{TextWebSocketFrame}}, but
> there is no reason why it shouldn't accept {{BinaryWebSocketFrame}} as well,
> especially seeing that STOMP supports binary payloads. Some WebSocket clients
> insist on sending binary packets under certain circumstances, for example
> https://github.com/theturtle32/WebSocket-Node does.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
