[
https://issues.apache.org/jira/browse/AMQ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315688#comment-15315688
]
ASF GitHub Bot commented on AMQ-6310:
-------------------------------------
GitHub user JonathanMalek opened a pull request:
https://github.com/apache/activemq/pull/188
AMQ-6310 added a check to ensure the leading wildcards in prefixes are
handled correctly.
Checking for leading wildcard in the prefix for a virtualtopic, modifying
the behavior of shouldDispatch in the VirtualTopicInterceptor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JonathanMalek/activemq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit 6bf5987921f6fdb6844652bb77e2fc14b002ccf2
Author: Jonathan Malek <[email protected]>
Date: 2016-06-04T23:51:27Z
A fix for AMQ-6310
Checking for leading wildcard in the prefix for a virtualtopic,
modifying the behavior of shouldDispatch in the VirtualTopicInterceptor.
----
> Certain VirtualTopic configurations no longer send messages to the correct
> queue
> --------------------------------------------------------------------------------
>
> Key: AMQ-6310
> URL: https://issues.apache.org/jira/browse/AMQ-6310
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.13.0
> Reporter: Jonathan Malek
>
> Several of our brokers have a VirtualTopic with the name {{VirtualTopic.>}}
> and a prefix of {{\*.\*.}}. The expected behavior would be that a message
> sent to {{VirtualTopic.A}} should be consumed on a queue with any pattern
> that matches {{\*.\*.VirtualTopic.A}}.
> For example, if a message is published to a topic called {{VirtualTopic.A}},
> that would be consumed on queues {{Consumer.A.VirtualTopic.A}} and
> {{Subscriber.A.VirtualTopic.A}}.
> However, since the change made in AMQ-6058, it appears that, given the
> example above, _neither_ queue receives the message. This is because the
> change performs a startsWith comparison of the destination against the
> prefix, rather than a regex comparison.
> If there is a reason to prevent leading wildcards in the prefix, it should be
> documented, otherwise the sanity check in shouldDispatch(...) needs to be
> updated to handle it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
