[ 
https://issues.apache.org/jira/browse/ARTEMIS-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401909#comment-15401909
 ] 

ASF GitHub Bot commented on ARTEMIS-642:
----------------------------------------

Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/672#discussion_r72964784
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
 ---
    @@ -162,6 +164,14 @@ public int getReconnectID() {
           return sessionChannel.getReconnectID();
        }
     
    +   public boolean isKilled() {
    +      return killed;
    +   }
    +
    +   public void kill(boolean killed) {
    --- End diff --
    
    Sorry, I wasn't clear.  When I mentioned `kill()` I was thinking:
    
    ```
    public void kill() {
       this.killed = true;
    }
    ```
    
    This way the caller isn't directly modifying the variable.  But no big deal.


> Disable slow client reconnecting with KILL slow client policy
> -------------------------------------------------------------
>
>                 Key: ARTEMIS-642
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-642
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>    Affects Versions: 1.3.0
>            Reporter: Chen Maoqian
>            Priority: Minor
>
> It is possible to detect and handle(KILL, NOTIFY) slow consumers. In case 
> policy KILL is used and connection factory used to create connection of slow 
> consumer has attribute reconnect-attempts set to "-1", slow consumer 
> reconnects to server. This consumer is then reconnects, is detected as slow 
> and disconnected. 
> Attribute reconnect-attempts="-1" should be ignored, and slow client should 
> not be trying to reconnect once it is disconnected by KILL slow consumer 
> policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to