[
https://issues.apache.org/jira/browse/ARTEMIS-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401910#comment-15401910
]
ASF GitHub Bot commented on ARTEMIS-642:
----------------------------------------
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/672#discussion_r72964880
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java
---
@@ -387,4 +388,15 @@ public void setClientID(String cID) {
public String getClientID() {
return clientID;
}
+
+ @Override
+ public void killMessage(SimpleString nodeID) throws Exception {
+ if (clientVersion <
DisconnectConsumerWithKillMessage.VERSION_INTRODUCED) {
+ throw new Exception(String.valueOf(clientVersion));
--- End diff --
Can this be a more specific ActiveMQ Exception? Even if its just
`ActiveMQException`
> Disable slow client reconnecting with KILL slow client policy
> -------------------------------------------------------------
>
> Key: ARTEMIS-642
> URL: https://issues.apache.org/jira/browse/ARTEMIS-642
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 1.3.0
> Reporter: Chen Maoqian
> Priority: Minor
>
> It is possible to detect and handle(KILL, NOTIFY) slow consumers. In case
> policy KILL is used and connection factory used to create connection of slow
> consumer has attribute reconnect-attempts set to "-1", slow consumer
> reconnects to server. This consumer is then reconnects, is detected as slow
> and disconnected.
> Attribute reconnect-attempts="-1" should be ignored, and slow client should
> not be trying to reconnect once it is disconnected by KILL slow consumer
> policy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
