[ 
https://issues.apache.org/jira/browse/ARTEMIS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510318#comment-15510318
 ] 

ASF GitHub Bot commented on ARTEMIS-743:
----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/787#discussion_r79863944
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
 ---
    @@ -1290,10 +1291,7 @@ protected ServerSessionImpl 
internalCreateSession(String name,
                                                          SessionCallback 
callback,
                                                          OperationContext 
context,
                                                          boolean 
autoCreateJMSQueues) throws Exception {
    -      return new ServerSessionImpl(name, username, password, 
validatedUser, minLargeMessageSize, autoCommitSends, autoCommitAcks, 
preAcknowledge, configuration.isPersistDeliveryCountBeforeDelivery(),
    -                                   xa, connection, storageManager, 
postOffice, resourceManager, securityStore, managementService, this, 
configuration.getManagementAddress(),
    -                                   defaultAddress == null ? null : new 
SimpleString(defaultAddress), callback, context, autoCreateJMSQueues ? 
jmsQueueCreator : null,
    -                                   pagingManager);
    +      return new ServerSessionImpl(name, username, password, 
validatedUser, minLargeMessageSize, autoCommitSends, autoCommitAcks, 
preAcknowledge, configuration.isPersistDeliveryCountBeforeDelivery(), xa, 
connection, storageManager, postOffice, resourceManager, securityStore, 
managementService, this, configuration.getManagementAddress(), defaultAddress 
== null ? null : new SimpleString(defaultAddress), callback, context, 
autoCreateJMSQueues ? jmsQueueCreator : null, pagingManager);
    --- End diff --
    
    Yes! 
    And then i'll squash the commit!


> Default the queue address to the queue name
> -------------------------------------------
>
>                 Key: ARTEMIS-743
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-743
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>            Reporter: Francesco Nigro
>              Labels: features
>
> In many instances, users will want the queue name and address to be the same. 
> The latter could default to the queue name, and then it would be safe to omit 
> the address in the queue config.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to