[ 
https://issues.apache.org/jira/browse/ARTEMIS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511079#comment-15511079
 ] 

ASF GitHub Bot commented on ARTEMIS-743:
----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/787#discussion_r79924952
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueConfig.java
 ---
    @@ -0,0 +1,242 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.core.server;
    +
    +import org.apache.activemq.artemis.api.core.SimpleString;
    +import org.apache.activemq.artemis.core.filter.Filter;
    +import org.apache.activemq.artemis.core.filter.FilterUtils;
    +import org.apache.activemq.artemis.core.paging.PagingManager;
    +import org.apache.activemq.artemis.core.paging.cursor.PageSubscription;
    +
    +public final class QueueConfig {
    +
    +   private final long id;
    +   private final SimpleString address;
    +   private final SimpleString name;
    +   private final Filter filter;
    +   private final PageSubscription pageSubscription;
    +   private final SimpleString user;
    +   private final boolean durable;
    +   private final boolean temporary;
    +   private final boolean autoCreated;
    +
    +   public static final class Builder {
    +
    +      private final long id;
    +      private final SimpleString address;
    +      private final SimpleString name;
    +      private Filter filter;
    +      private PagingManager pagingManager;
    +      private SimpleString user;
    +      private boolean durable;
    +      private boolean temporary;
    +      private boolean autoCreated;
    +
    +      private Builder(final long id, final SimpleString name) {
    +         this(id, name, name);
    +      }
    +
    +      private Builder(final long id, final SimpleString name, final 
SimpleString address) {
    +         //TODO Checks if what are valid default values and/or enforces 
not mandatory fields to be on Builder's constructor
    +         this.id = id;
    +         this.name = name;
    +         this.address = address;
    +         this.filter = null;
    +         this.pagingManager = null;
    +         this.user = null;
    +         this.durable = true;
    +         this.temporary = false;
    +         this.autoCreated = true;
    +         validateState();
    +      }
    +
    +      //TODO maybe an SimpleString::isEmpty method would be welcome
    --- End diff --
    
    I would remove this TODO as well.


> Default the queue address to the queue name
> -------------------------------------------
>
>                 Key: ARTEMIS-743
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-743
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>            Reporter: Francesco Nigro
>              Labels: features
>
> In many instances, users will want the queue name and address to be the same. 
> The latter could default to the queue name, and then it would be safe to omit 
> the address in the queue config.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to