[
https://issues.apache.org/jira/browse/ARTEMIS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586255#comment-15586255
]
ASF GitHub Bot commented on ARTEMIS-793:
----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/839#discussion_r83920218
--- Diff:
artemis-server-osgi/src/main/java/org/apache/activemq/artemis/osgi/ProtocolTrackerCallBack.java
---
@@ -25,4 +25,6 @@
void addFactory(ProtocolManagerFactory<Interceptor> pmf);
void removeFactory(ProtocolManagerFactory<Interceptor> pmf);
+
+ void setDataSourceDependency(boolean dataSourceDependency);
--- End diff --
what about renaming this to:
addDataSource(WhateverInformationForTheDatasource);
the callback could then decide what to do.
the best would be to have a class extending ProtocolTrackerCallback:
ServerTrackerCallback extends ProtocolTrackerCallback
And at the caller we would check an instanceof.
Would that be possible with OSGI?
BTW: thanks for rebasing... at least I can comment on these changes now.
> Improvement to OSGi integration
> --------------------------------
>
> Key: ARTEMIS-793
> URL: https://issues.apache.org/jira/browse/ARTEMIS-793
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker, osgi
> Reporter: Benjamin Graf
> Fix For: 1.5.0
>
>
> ARTEMIS-714 adds ability to configure external DataSource for usage instead
> of hardcoded driver. This feature should also be usable in OSGi environments
> like Karaf.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
