[ 
https://issues.apache.org/jira/browse/ARTEMIS-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944987#comment-15944987
 ] 

ASF GitHub Bot commented on ARTEMIS-1073:
-----------------------------------------

Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1138#discussion_r108394942
  
    --- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml
 ---
    @@ -61,10 +61,13 @@ 
${ping-config.settings}${journal-buffer.settings}${connector-config.settings}
           <global-max-size>100Mb</global-max-size>
     
           <acceptors>
    +
              <!-- useEpoll means: it will use Netty epoll if you are on a 
system (Linux) that supports it -->
    +         <!-- amqpCredits: The number of credits sent to AMQP producers -->
    +         <!-- amqpLowCredits: The server will send the # credits specified 
at amqpCredits at this low mark -->
    --- End diff --
    
    Should there maybe be some coverage of these options in the documentation? 
Do we think enough people will tweak them that they should be in the default 
configuration file?


> Exposing AMQP Credits, and setting the default credits to 1000
> --------------------------------------------------------------
>
>                 Key: ARTEMIS-1073
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1073
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: clebert suconic
>            Assignee: clebert suconic
>             Fix For: 2.next
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to