[
https://issues.apache.org/jira/browse/ARTEMIS-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944986#comment-15944986
]
ASF GitHub Bot commented on ARTEMIS-1073:
-----------------------------------------
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1138#discussion_r108394675
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/amqp-acceptor.txt
---
@@ -1,3 +1,3 @@
<!-- AMQP Acceptor. Listens on default AMQP port for AMQP
traffic.-->
- <acceptor
name="amqp">tcp://${host}:${amqp.port}?protocols=AMQP;useEpoll=true</acceptor>
+ <acceptor
name="amqp">tcp://${host}:${amqp.port}?protocols=AMQP;useEpoll=true;amqpCredits=1000;amqpMinCredits=300</acceptor>
--- End diff --
This configures 'amqpMinCredits', whereas broker.xml configures
'amqpLowCredits', is one of them wrong? If not, perhaps it would be clearer if
they were the same?
It might also be clearer to rationalise the naming in the code as well, it
seems to use 'amqpLowMark', 'amqpLowCredits', and 'minCreditRefresh' to refer
to this.
> Exposing AMQP Credits, and setting the default credits to 1000
> --------------------------------------------------------------
>
> Key: ARTEMIS-1073
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1073
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Fix For: 2.next
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
