[
https://issues.apache.org/jira/browse/ARTEMIS-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986632#comment-15986632
]
ASF GitHub Bot commented on ARTEMIS-904:
----------------------------------------
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/1231
ARTEMIS-904 Remove cyclic dependencies from artemis-cli
move classes and methods to their correct location to avoid cyclic
dependencies between packages and classes. I also removed unused methods.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bennetelli/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1231
----
commit 1993e14c224eabae63b8432c0cbce5f6b78cb2d1
Author: Bennet Schulz <[email protected]>
Date: 2017-04-27T13:36:38Z
ARTEMIS-904 Remove cyclic dependencies from artemis-cli
move classes and methods to their correct location to avoid cyclic
dependencies between packages and classes.
----
> Remove cyclic dependencies from artemis-cli
> -------------------------------------------
>
> Key: ARTEMIS-904
> URL: https://issues.apache.org/jira/browse/ARTEMIS-904
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Bennet Schulz
>
> The project needs some smaller refactorings. Some methods should be moved to
> another class which is responsible it (e.g. printBanner() in Artemis class
> should be moved to PrintData class.
> In addition to this simple case there are lots of other classes/packages
> which have cyclic dependencies.
> I already did such a refactoring for artemis-jdbc. (ARTEMIS-830 Remove cyclic
> dependencies from artemis-jdbc-store)
> We should track all our dependencies between classes and packages as the
> Spring guys do since quite a while
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
