[
https://issues.apache.org/jira/browse/ARTEMIS-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986750#comment-15986750
]
ASF GitHub Bot commented on ARTEMIS-904:
----------------------------------------
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1231#discussion_r113715125
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/util/ServerUtil.java ---
@@ -121,18 +121,6 @@ public static int getServer(Connection connection) {
return Integer.valueOf(port) - 61616;
}
- public static Connection getServerConnection(int server, Connection...
connections) {
- for (Connection connection : connections) {
- ClientSession session = ((ActiveMQConnection)
connection).getInitialSession();
- TransportConfiguration transportConfiguration =
session.getSessionFactory().getConnectorConfiguration();
- String port = (String)
transportConfiguration.getParams().get("port");
- if (Integer.valueOf(port) == server + 61616) {
- return connection;
- }
- }
- return null;
- }
-
--- End diff --
This method is used in the "clustered-static-oneway" example.
> Remove cyclic dependencies from artemis-cli
> -------------------------------------------
>
> Key: ARTEMIS-904
> URL: https://issues.apache.org/jira/browse/ARTEMIS-904
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Bennet Schulz
>
> The project needs some smaller refactorings. Some methods should be moved to
> another class which is responsible it (e.g. printBanner() in Artemis class
> should be moved to PrintData class.
> In addition to this simple case there are lots of other classes/packages
> which have cyclic dependencies.
> I already did such a refactoring for artemis-jdbc. (ARTEMIS-830 Remove cyclic
> dependencies from artemis-jdbc-store)
> We should track all our dependencies between classes and packages as the
> Spring guys do since quite a while
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
