[ https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009203#comment-16009203 ]
ASF GitHub Bot commented on ARTEMIS-1162: ----------------------------------------- Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1268 @michaelandrepearce Nope, no problem for me...but I'm not 100% sure is the best way to do it: changing the new one to be like the original one is a matter of 1 line change and a boolean flag to be put in the right spot. Instead of having: ``` if (checkpoint || currentPendingSyncs >= estimatedOptimalBatch) { ``` Need to be changed into: ``` if (checkpoint || (smartCoalescing && currentPendingSyncs >= estimatedOptimalBatch)) { ``` Finished. Now you have one implementation that cover the 2 behaviours. wdyt? > Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable > -------------------------------------------------------------------- > > Key: ARTEMIS-1162 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1162 > Project: ActiveMQ Artemis > Issue Type: Improvement > Affects Versions: 2.1.0 > Reporter: Michael Andre Pearce > Fix For: 2.2.0 > > > New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. > This could cause behaviour/performance change of journal IO (and hopefully > for the better). > As this hasn't been run significantly in a real world production environment, > to avoid causing any production deployment issues having unexpected behaviour > changes, or to allow managed rollout and rollback. > We would like to add back the fixed timed buffer (default), and make it > configurable to the new improved timed buffer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)