[
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009214#comment-16009214
]
ASF GitHub Bot commented on ARTEMIS-1162:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1268
For me is ok to have an enum, but I mean that it doesn't make sense to have
2 TimedBuffer implementations.
You can have one with a flag in the constructor to disable the coalescing:
this way the behaviours will be the same as before, but with off heap batch
buffer + bulk copy too.
Then you can you an enum to set that flag or not: it is simpler to maintain
IMHO.
It is different if you want to maintain the older things that wasn't good
(heap buffers + no bulk copy)...this is what you're proposing?
> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> --------------------------------------------------------------------
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer.
> This could cause behaviour/performance change of journal IO (and hopefully
> for the better).
> As this hasn't been run significantly in a real world production environment,
> to avoid causing any production deployment issues having unexpected behaviour
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it
> configurable to the new improved timed buffer.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
