[
https://issues.apache.org/jira/browse/ARTEMIS-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115522#comment-16115522
]
ASF GitHub Bot commented on ARTEMIS-1324:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530423
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
@@ -608,6 +608,14 @@ public void parseMainConfig(final Element e, final
Configuration config) throws
config.setNetworkCheckPingCommand(getString(e,
"network-check-ping-command", config.getNetworkCheckPingCommand(),
Validators.NO_CHECK));
+ config.setAnalyzeCritical(getBoolean(e, "analyze-critical",
config.isAnalyzeCritical()));
+
+ config.setAnalyzeCriticalTimeout(getLong(e,
"analyze-critical-timeout", config.getAnalyzeCriticalTimeout(),
Validators.GE_ZERO));
+
+ config.setAnalyzeCriticalCheckPeriod(getLong(e,
"analyze-critical-check-period", config.getAnalyzeCriticalCheckPeriod(),
Validators.GE_ZERO));
--- End diff --
as per other review comment should the default not be half the timeout if
it is not set, not some arbitarty number which then forces the section of code
later.
> Critical Analysis and deadlock detection on broker
> --------------------------------------------------
>
> Key: ARTEMIS-1324
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1324
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Critical
> Fix For: 2.3.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
