[
https://issues.apache.org/jira/browse/ARTEMIS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115540#comment-16115540
]
ASF GitHub Bot commented on ARTEMIS-1308:
-----------------------------------------
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1428
@clebertsuconic @franz1981 i believe i have this PR working except i am
getting one test failure, see below.
https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/3570/testReport/junit/org.apache.activemq.artemis.tests.unit.core.journal.impl/TimedBufferTest/testTimeOnTimedBuffer/
Is this related at all to:
https://github.com/apache/activemq-artemis/pull/1435
Or the other TimedBuffer work? If not any ideas what this is, i haven't
touched this area at all for this PR so doesn't make sense to me.
Cheers
Mike
> Client Acknowledge not performant
> ---------------------------------
>
> Key: ARTEMIS-1308
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1308
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.2.0
> Reporter: Michael Andre Pearce
> Assignee: clebert suconic
> Priority: Critical
> Fix For: 2.3.0
>
>
> Artemis recommendation in docs is to use CLIENT_ACKNOWLEDGE instead of
> AUTO_ACKNOWLEDGE, on perf testing it seems this is not the case.
> On checking code it seems the reason for this is because ActiveMQMessage
> acknowledge actually calls session.commit, causing a full session commit all
> the time.
> On checking Core API, calling message.acknowledge it seems to behave as
> expected, as such believe this to be an issue in JMS api wrapper, that it
> should just be delegating to the ClientMessage.acknowledge method and this is
> the cause of the perf issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
