[ 
https://issues.apache.org/jira/browse/ARTEMIS-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116642#comment-16116642
 ] 

ASF GitHub Bot commented on ARTEMIS-1326:
-----------------------------------------

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1444
  
    The test was correct before.
    
    This write here would flush the buffer right away and a new write would be 
issued:
    
https://github.com/apache/activemq-artemis/blob/f12116d5a54fbaa2f2507293bb6d524ec3012fa7/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/TimedBufferTest.java#L195-L196
    
    
    The burst cannot complete in less than the timeout.. otherwise the timed 
buffer is not timing...
    
    I would revert this change... or provide more info on where it failed.


> testTimeOnTimedBuffer incorrect timeout count
> ---------------------------------------------
>
>                 Key: ARTEMIS-1326
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1326
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>
> The test isn't evaluating the timeout expiration while writing in batches 
> into the TimedBuffer



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to