[
https://issues.apache.org/jira/browse/ARTEMIS-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116686#comment-16116686
]
ASF GitHub Bot commented on ARTEMIS-1326:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1444
@clebertsuconic
> The burst cannot complete in less than the timeout.. otherwise the timed
buffer is not timing...
A burst can complete in less than a timeout (reading the callback calls in
the test) but a new one can be accepted only when the timeout will be expired:
that's what a sanity test should verify IMHO.
Logging the different states of the TimedBuffer in the old and the new
version help to understand this little difference.
Reverting it would make it a step back from the correctness point of view
IMHO and features equality between NIO/MAPPED/ASYNCIO, because now (after the
last change you suggested me) it is really timing with the correct timeout...
@mtaylor @michaelandrepearce have worked around these code paths too,
wdyt?
> testTimeOnTimedBuffer incorrect timeout count
> ---------------------------------------------
>
> Key: ARTEMIS-1326
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1326
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
>
> The test isn't evaluating the timeout expiration while writing in batches
> into the TimedBuffer
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
