[ 
https://issues.apache.org/jira/browse/ARTEMIS-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168329#comment-16168329
 ] 

ASF GitHub Bot commented on ARTEMIS-1422:
-----------------------------------------

Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1537#discussion_r139223158
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/HierarchicalObjectRepository.java
 ---
    @@ -94,6 +99,11 @@
         */
        private final ArrayList<HierarchicalRepositoryChangeListener> listeners 
= new ArrayList<>();
     
    +   public HierarchicalObjectRepository(final WildcardConfiguration 
wildcardConfiguration) {
    --- End diff --
    
    I'd rather see a default constructor which calls this one so all the places 
in the code-base which use the default WildcardConfiguration don't have to be 
changed to pass in `new WildcardConfiguration()` or `null`.


> Redeploy test broken after matching logic update
> ------------------------------------------------
>
>                 Key: ARTEMIS-1422
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1422
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to