[ 
https://issues.apache.org/jira/browse/ARTEMIS-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168462#comment-16168462
 ] 

ASF GitHub Bot commented on ARTEMIS-1422:
-----------------------------------------

Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1537#discussion_r139241507
  
    --- Diff: 
tests/integration-tests/src/test/resources/reload-address-queues-updated.xml ---
    @@ -111,7 +111,12 @@ under the License.
                 <config-delete-addresses>FORCE</config-delete-addresses>
              </address-setting>
           </address-settings>
    -      
    +
    +      <wildcard-addresses>
    +         <enabled>true</enabled>
    --- End diff --
    
    I believe the only place isEnabled is checked is when the PostOffice is 
constructed.  If it is enabled then a 
`org.apache.activemq.artemis.core.postoffice.impl.WildcardAddressManager` is 
used otherwise a 
`org.apache.activemq.artemis.core.postoffice.impl.SimpleAddressManager` is 
used.  This effectively enables/disables wildcard address *routing*.  This is 
technically different than address *matching*.


> Redeploy test broken after matching logic update
> ------------------------------------------------
>
>                 Key: ARTEMIS-1422
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1422
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to