[ 
https://issues.apache.org/jira/browse/ARTEMIS-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194636#comment-16194636
 ] 

ASF GitHub Bot commented on ARTEMIS-1452:
-----------------------------------------

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1578
  
    @franz1981 
https://github.com/apache/activemq-artemis/blob/37135617a8776c91c7e598ff11aa8bbc240ceafe/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFileFactory.java#L80-L83
    
    
    All you need is to set journal-timeout = 0... which wasn't being allowed on 
the config (> 0).. I basically changed it allowing >= 0 and that's the change.
    
    
    Regarding MAPPED.. I didn't merge that one before because I thought we were 
lacking tests... I had a test on my workspace for Unbuffered.. but I think I 
missed it...
    
    
    I think we should change the CLI to make timeout = 0 if sync = false (for 
all the journals.. not just MAPPED).  and add a text on the broker.xml saying 
we recommend disabling if sync=false.


> Journal Configuration Improvements
> ----------------------------------
>
>                 Key: ARTEMIS-1452
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1452
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.3.0
>            Reporter: clebert suconic
>            Assignee: clebert suconic
>             Fix For: 2.4.0
>
>
> When using more advanced systems, that are capable of doing a lot more queued 
> IO, the self optimization of the journal is not really being optimal.
> Besides It would be nice to have some of the configurations more explicit on 
> broker.xml
> And also, we should allow users to disable the TimedBuffering. By simply 
> using 0 at the journal-buffer-timeout.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to