[
https://issues.apache.org/jira/browse/ARTEMIS-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194702#comment-16194702
]
ASF GitHub Bot commented on ARTEMIS-1452:
-----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1578
it doesn't extend indeed.. I thought it did...
but you still inherited the code with copy & paste :)
```java
if (buffered && bufferTimeout > 0 && bufferSize > 0) {
timedBuffer = new TimedBuffer(bufferSize, bufferTimeout, false);
} else {
timedBuffer = null;
}
```
perhaps it should extend it?
> Journal Configuration Improvements
> ----------------------------------
>
> Key: ARTEMIS-1452
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1452
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.3.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Fix For: 2.4.0
>
>
> When using more advanced systems, that are capable of doing a lot more queued
> IO, the self optimization of the journal is not really being optimal.
> Besides It would be nice to have some of the configurations more explicit on
> broker.xml
> And also, we should allow users to disable the TimedBuffering. By simply
> using 0 at the journal-buffer-timeout.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
