[
https://issues.apache.org/jira/browse/ARTEMIS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197590#comment-16197590
]
ASF GitHub Bot commented on ARTEMIS-1447:
-----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
for the JdbcNodeManager:
The package server.impl is already bloated.. I tried once to refactor it
into smaller packages...
This is a nice abstract model you have, but instead of the big class, cal
you create a packet jdbcNodeManager, and add your classes there?
Also, instead of creating your own scheduledExecutor.. Please extend
ActiveMQScheduledComponent... if you can reuse the same executors that we
already have created, just pass in the scheduledService as a parameter... and
if you must create a new ScheduledService, you can still use the same class for
that.
> JDBC NodeManager to support JDBC HA Shared Store
> ------------------------------------------------
>
> Key: ARTEMIS-1447
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1447
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
> Reporter: Francesco Nigro
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
