[
https://issues.apache.org/jira/browse/ARTEMIS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201660#comment-16201660
]
ASF GitHub Bot commented on ARTEMIS-1447:
-----------------------------------------
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
@franz1981 I think using a single class to hold the database statements is
fine. Splitting this up into several classes would mean that every provider
would have to override 3 or 4 classes just to change the DB statements. Unless
there's a technical reason to do it, like having to use two tables in a single
statement, then I wouldn't bother.
Another note. I haven't checked these statements work with Derby, but I
don't see any overrides in Oracle12C provider. Please ensure that the tests
run and pass with Derby, as this is the default provider in our test suite.
Override them in Oracle12C etc...
> JDBC NodeManager to support JDBC HA Shared Store
> ------------------------------------------------
>
> Key: ARTEMIS-1447
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1447
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
> Reporter: Francesco Nigro
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
