[
https://issues.apache.org/jira/browse/ARTEMIS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212391#comment-16212391
]
ASF GitHub Bot commented on ARTEMIS-1472:
-----------------------------------------
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1601#discussion_r145906975
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/Events.java
---
@@ -92,6 +97,9 @@ public static void dispatch(Event event, EventHandler
handler) throws Exception
handler.onDelivery(event.getDelivery());
break;
default:
+ if (PN_TRACE_FRM) {
+ logger.info("event: " + event + " not being treated");
--- End diff --
This also doesn't feel like it should be tied to having proton trace its
frames to me, I'd just make this a regular trace logger.
> Use PN_TRACE_FRAME as a signal for System.out logging on AMQP events
> --------------------------------------------------------------------
>
> Key: ARTEMIS-1472
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1472
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.3.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Fix For: 2.4.0
>
>
> AMQP developers will usually set PN_TRACE_FRM as a System.property to get out
> some information from Proton regarding the frame processing.
> It would be a nice idea to also throw some log.info when that property is set
> at Artemis.. around AMQP Processing, making it easier to Debug AMQP packets.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
