[
https://issues.apache.org/jira/browse/ARTEMIS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212388#comment-16212388
]
ASF GitHub Bot commented on ARTEMIS-1472:
-----------------------------------------
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1601#discussion_r145906703
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
---
@@ -143,13 +144,26 @@ public SASLResult getSASLResult() {
}
public void inputBuffer(ByteBuf buffer) {
- if (log.isTraceEnabled()) {
- ByteUtil.debugFrame(log, "Buffer Received ", buffer);
+ if (PN_TRACE_FRM) {
+ debugFrame(buffer);
}
handler.inputBuffer(buffer);
}
+ private static void debugFrame(ByteBuf byteIn) {
+ int location = byteIn.readerIndex();
+ // debugging
+ byte[] frame = new byte[byteIn.writerIndex()];
+ byteIn.readBytes(frame);
+
+ if (PN_TRACE_FRM) {
--- End diff --
This was checked already before calling the method. Ignoring that it would
probably also be better done around the whole contents of the method to avoid
creating the byte array but then not using it and then needing to readjust the
buffer index later.
> Use PN_TRACE_FRAME as a signal for System.out logging on AMQP events
> --------------------------------------------------------------------
>
> Key: ARTEMIS-1472
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1472
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.3.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Fix For: 2.4.0
>
>
> AMQP developers will usually set PN_TRACE_FRM as a System.property to get out
> some information from Proton regarding the frame processing.
> It would be a nice idea to also throw some log.info when that property is set
> at Artemis.. around AMQP Processing, making it easier to Debug AMQP packets.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
