[
https://issues.apache.org/jira/browse/ARTEMIS-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212586#comment-16212586
]
ASF GitHub Bot commented on ARTEMIS-1474:
-----------------------------------------
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1602
ARTEMIS-1474 TimedBuffer need sleep error detection measured against the
expected timeout
It contains:
- customization of the timeout error percentage (for development)
- refactored logic around constant value evaluations
- reused (but refactored) the old timeout error detection logic while
sleeping
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis
timed_buffer_timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1602.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1602
----
commit 826ff5aa04270d1413551d8aaebadb2f14058ee9
Author: Francesco Nigro <[email protected]>
Date: 2017-10-20T12:38:39Z
ARTEMIS-1474 TimedBuffer need sleep error detection measured against the
expected timeout
It contains:
- customization of the timeout error percentage (for development)
- refactored logic around constant value evaluations
- reused (but refactored) the old timeout error detection logic while
sleeping
----
> TimedBuffer need sleep error detection measured against the expected timeout
> ----------------------------------------------------------------------------
>
> Key: ARTEMIS-1474
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1474
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> The current TimedBuffer implementation evaluate the sleep accuracy measuring
> the error against the elapsed sleep time while the original version was using
> the error related to the overall expected timeout: It would be better due to
> the sleep/parkNanos behaviour to maintain the original evaluation method, but
> using the improved discounted (with the last flush time) sleep time in order
> to not exeeding to delay flushes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
