[
https://issues.apache.org/jira/browse/ARTEMIS-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212716#comment-16212716
]
ASF GitHub Bot commented on ARTEMIS-1474:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1602
@clebertsuconic
The point of the PR is to restore the original timeout error detection but
use the new discounted sleep (it is the description of the PR!): I can remove
the property for the reasons you mentioned, while the rest of code refactoring
was done to simplify and/or make explicit/document the existing logic.
> TimedBuffer need sleep error detection measured against the expected timeout
> ----------------------------------------------------------------------------
>
> Key: ARTEMIS-1474
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1474
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> The current TimedBuffer implementation evaluate the sleep accuracy measuring
> the error against the elapsed sleep time while the original version was using
> the error related to the overall expected timeout: It would be better due to
> the sleep/parkNanos behaviour to maintain the original evaluation method, but
> using the improved discounted (with the last flush time) sleep time in order
> to not exeeding to delay flushes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
