[
https://issues.apache.org/jira/browse/ARTEMIS-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256221#comment-16256221
]
ASF GitHub Bot commented on ARTEMIS-1516:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1659#discussion_r151577088
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
@@ -88,20 +83,6 @@
private boolean finalizeChecks;
- @Override
- public void writeExternal(ObjectOutput out) throws IOException {
- URI uri = toURI();
-
- try {
- out.writeUTF(uri.toASCIIString());
--- End diff --
Wouldn't this will break compatibility.
Think of anyone serializing this class.
Looking at the JNDISTorage (new class) I see that this is calling now
writeObject(getProperties());
As opposed to the writeURI.
The point was to write a string to be better compatible between versions.
Can we add back the format we had here?
> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5
> -----------------------------------------------------------
>
> Key: ARTEMIS-1516
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1516
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Michael Andre Pearce
> Assignee: Michael Andre Pearce
>
> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5. JNDI
> serialisation needs to use StringRefAddr to support this.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
