[ 
https://issues.apache.org/jira/browse/ARTEMIS-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256595#comment-16256595
 ] 

ASF GitHub Bot commented on ARTEMIS-1516:
-----------------------------------------

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1659
  
    The serialisation change was actually needed for the fix, this is some of 
the actual issue.
    
    
    > On 17 Nov 2017, at 04:17, clebertsuconic <[email protected]> wrote:
    > 
    > The test failure is so weird. if you run the whole thing in Idea it 
fails.. individually it's passing.
    > 
    > I can see it's missing a property.. but I'm not sure what changed that 
user was at some point considered a property.. as the BeanUtil wasn't picking 
up builder pattern on setUser... so weird.
    > 
    > Anyways.. I sent a PR to your branch.. please squash it.
    > 
    > Only thing I'm concerned here is the wire change on the connection 
factory (as it was a string with the URI before)... and I'm not so sure if you 
really need to move those classes.. thinking this as an API change since 
Wildfly will probably need it.
    > 
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub 
<https://github.com/apache/activemq-artemis/pull/1659#issuecomment-345115665>, 
or mute the thread 
<https://github.com/notifications/unsubscribe-auth/ABUtLgcu7LPIG2FuPTUm4ALiIxQn_CVrks5s3N6kgaJpZM4QhAPN>.
    > 
    



> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-1516
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1516
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Michael Andre Pearce
>            Assignee: Michael Andre Pearce
>
> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5. JNDI 
> serialisation needs to use StringRefAddr to support this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to