[
https://issues.apache.org/jira/browse/ARTEMIS-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329468#comment-16329468
]
ASF GitHub Bot commented on ARTEMIS-1589:
-----------------------------------------
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1773
@jbertram @jostbg As far as I can see the patch looks correct, it would
seem to make more sense to return the remote container ID here than the locally
generated server side value as that provides more context into the remote
connection. That is of course if the getClientID API in RemotingConnection is
referring to the value specified by the remote, which would make the most
sense.
> ActiveMQProtonRemotingConnection#getClientID does not return remote client ID
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-1589
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1589
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.4.0
> Environment: Artemis 2.5.0-SNAPSHOT
> Reporter: Johan Stenberg
> Priority: Minor
>
> ActiveMQProtonRemotingConnection#getClientID currently returns the local
> container's clientID and not the actual (remote) client ID. Which it should
> from my interpretation of the JavaDoc at
> [RemotingConnection.java#L234|https://github.com/apache/activemq-artemis/blob/master/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java#L234]
> [StompConnection#getClientID|https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompConnection.java#L426]
> also returns the actual remote client ID.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
