[ 
https://issues.apache.org/jira/browse/ARTEMIS-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329509#comment-16329509
 ] 

ASF GitHub Bot commented on ARTEMIS-1589:
-----------------------------------------

Github user jostbg commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1773
  
    The java doc of getClientID says "Returns the Client ID associated with 
this connection" which probably refers to the "client-side" ID. StompConnection 
for example returns the ID set by the client and not some server generated ID. 


> ActiveMQProtonRemotingConnection#getClientID does not return remote client ID
> -----------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1589
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1589
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.4.0
>         Environment: Artemis 2.5.0-SNAPSHOT
>            Reporter: Johan Stenberg
>            Priority: Minor
>
> ActiveMQProtonRemotingConnection#getClientID currently returns the local 
> container's clientID and not the actual (remote) client ID. Which it should 
> from my interpretation of the JavaDoc at 
> [RemotingConnection.java#L234|https://github.com/apache/activemq-artemis/blob/master/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java#L234]
> [StompConnection#getClientID|https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompConnection.java#L426]
>  also returns the actual remote client ID.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to