[ https://issues.apache.org/jira/browse/ARTEMIS-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343407#comment-16343407 ]
ASF GitHub Bot commented on ARTEMIS-550: ---------------------------------------- Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1820#discussion_r164445884 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java --- @@ -698,8 +699,17 @@ private ActiveMQMessageConsumer createConsumer(final ActiveMQDestination dest, */ if (!response.isExists() || !response.getQueueNames().contains(dest.getSimpleAddress())) { if (response.isAutoCreateQueues()) { + SimpleString queueNameToUse = dest.getSimpleAddress(); + SimpleString addressToUse = queueNameToUse; + RoutingType routingTypeToUse = RoutingType.ANYCAST; + if (CompositeAddress.isFullyQualified(queueNameToUse.toString())) { + CompositeAddress compositeAddress = CompositeAddress.getQueueName(queueNameToUse.toString()); + addressToUse = new SimpleString(compositeAddress.getAddress()); + queueNameToUse = new SimpleString(compositeAddress.getQueueName()); + routingTypeToUse = RoutingType.MULTICAST; --- End diff -- @michaelandrepearce I agree with you, I will close out this PR. The discussion is the valuable bit. For this use case, SDS is the answer. For the more general CORE FQQN scenario, using a prefix with a FQQN would be the other approach. It probably should support the prefix notation via the acceptor. ```multicast://VirtualTopic.Orders::Consumer.A``` This says, create me a sub queue called ```Consumer.A`` that is bound using ```multicast``` routing to address ```VirtualTopic.Orders```. > Add support for virtual topic consumers > --------------------------------------- > > Key: ARTEMIS-550 > URL: https://issues.apache.org/jira/browse/ARTEMIS-550 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker > Affects Versions: 1.3.0 > Reporter: Benjamin Graf > Assignee: Martyn Taylor > Priority: Major > Attachments: image-2018-01-26-09-02-08-192.png > > > Artemis should support virtual topic consumers as alternative to topic > subscriptions as ActiveMQ itself does. -- This message was sent by Atlassian JIRA (v7.6.3#76005)