ASF subversion and git services commented on ARTEMIS-1650:

Commit 822445a717f943c64a84b2ac6a0af8ace9e5cd23 in activemq-artemis's branch 
refs/heads/master from [~huaishk]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=822445a ]

ARTEMIS-1650 Improve paged message acknowledge

Cache `messageID`, `transactionID` and `isLargeMessage`
in PagedReference, so that when acknowledge, we do not have to
get PagedMessage which may be GCed and cause re-read entire page.

> Improve paged message acknowledge
> ---------------------------------
>                 Key: ARTEMIS-1650
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1650
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>            Reporter: shoukun huai
>            Priority: Minor
>         Attachments: jstack.txt
> PagedMessage may be GCed before it was acknowledged. In this case, server has 
> to reload the page and hold the page cache lock, then block other consumers 
> of the same queue.
> When do acknowledge, we need at least message id, transaction id, and is 
> large message.
> We believe the three property can be added to PagedReference, so we do not 
> rely on PagedMessage when acknowledge except LargeMessage.

This message was sent by Atlassian JIRA

Reply via email to