[
https://issues.apache.org/jira/browse/ARTEMIS-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447074#comment-16447074
]
ASF GitHub Bot commented on ARTEMIS-1822:
-----------------------------------------
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2037
The commit message should contain the JIRA, e.g.
> ARTEMIS-1822 Change the method name 'lookupRecord' to 'containsRecord'
Also, I noticed you've opened lots of similar PRs recently on other (mainly
Apache) projects - seven just today! I'm curious if you have some kind of
automated tool you're using or if you are finding these methods manually.
> Inconsistent method name
> ------------------------
>
> Key: ARTEMIS-1822
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1822
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
>
> The following method is named "lookupRecord".
> "lookupRecord" seems to find a related record.
> But the method is checking whether recordsSnapshot contains the id or not.
> Thus, the method name "containsRecord" is more intuitive than "lookupRecord".
> {code:java}
> public boolean lookupRecord(final long id) {
> return recordsSnapshot.contains(id);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
