[ 
https://issues.apache.org/jira/browse/ARTEMIS-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447131#comment-16447131
 ] 

ASF GitHub Bot commented on ARTEMIS-1822:
-----------------------------------------

Github user BruceKuiLiu commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2037
  
    I have an automated tool that tries to identify such potential inconsistent 
method names and suggest new potential consistent names for them automatically.


> Inconsistent method name
> ------------------------
>
>                 Key: ARTEMIS-1822
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1822
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is named "lookupRecord".
> "lookupRecord" seems to find a related record.
> But the method is checking whether recordsSnapshot contains the id or not.
> Thus, the method name "containsRecord" is more intuitive than "lookupRecord".
> {code:java}
>    public boolean lookupRecord(final long id) {
>       return recordsSnapshot.contains(id);
>    }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to