[
https://issues.apache.org/jira/browse/ARTEMIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465840#comment-16465840
]
ASF GitHub Bot commented on ARTEMIS-1852:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2075#discussion_r186406297
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -239,8 +239,28 @@ public void stop() {
for (PageSubscription cursor : activeCursors.values()) {
cursor.stop();
}
-
- executor.shutdownNow();
+ int pendingCleanupTasks = scheduledCleanup.get();
--- End diff --
Nice catch.. very nice...
However.. I'm not sure why we were calling shutdown here. PageCursor
doesn't own the executor...
this is using ArtemisExecutor. where shutdownNow will call an empty
method.. and getPendingTasks will return also an empty array.
I think the only thing you should do here is call the flush method.
> PageCursorProvider is leaking cleanup tasks while stopping
> ----------------------------------------------------------
>
> Key: ARTEMIS-1852
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1852
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.5.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Fix For: 2.5.1
>
>
> PageCursorProviderImpl::stop is not handling any scheduled cleanup tasks on
> stop, leaving paging enabled due to the remaining pages to be
> cleared up.
> It fixes testTopicsWithNonDurableSubscription.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
