[
https://issues.apache.org/jira/browse/ARTEMIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465867#comment-16465867
]
ASF GitHub Bot commented on ARTEMIS-1852:
-----------------------------------------
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2075#discussion_r186412623
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -239,8 +239,28 @@ public void stop() {
for (PageSubscription cursor : activeCursors.values()) {
cursor.stop();
}
-
- executor.shutdownNow();
+ int pendingCleanupTasks = scheduledCleanup.get();
--- End diff --
`PagingStoreImpl` seems the one that is owning the executor
I will move the `executor.shutdownNow` from the `PageCursorProvider` to
`PagingStoreImpl` while leaving at least the flush of the cleanup tasks on it
:+1:
Good points!
> PageCursorProvider is leaking cleanup tasks while stopping
> ----------------------------------------------------------
>
> Key: ARTEMIS-1852
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1852
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.5.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Fix For: 2.5.1
>
>
> PageCursorProviderImpl::stop is not handling any scheduled cleanup tasks on
> stop, leaving paging enabled due to the remaining pages to be
> cleared up.
> It fixes testTopicsWithNonDurableSubscription.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
