[
https://issues.apache.org/jira/browse/ARTEMIS-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519757#comment-16519757
]
Justin Bertram commented on ARTEMIS-1950:
-----------------------------------------
Back on ARTEMIS-413 you actually noted that {{durable-subscriber-name}} was
required for creating a durable STOMP subscription before there was really any
documentation on the subject. During the work on that JIRA, plus the work on
ARTEMIS-548 the {{durable-subscriber-name}} header was deprecated and replaced
with {{durable-subscription-name}}. As noted previously, there was no existing
documentation on {{durable-subscriber-name}} at the time, and the newly added
documentation only referred to {{durable-subscription-name}}. It was not
removed so as to not break existing users. Deprecated items are typically
removed at a major release because users don't usually appreciate them being
removed before then.
I'll look at updating the documentation. For what it's worth, the
documentation is pretty simple to update. It uses the common markdown format.
If you notice issues feel free to send a PR.
Lastly, I wouldn't have expected a user to set _both_
{{durable-subscriber-name}} and {{durable-subscription-name}}. Is there a
particular use-case for that?
> Mismatch between durable-subscriber-name and durable-subscription-name
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-1950
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1950
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Lionel Cons
> Priority: Major
>
> The STOMP documentation describes the use of {{durable-subscription-name}}
> and does not mention {{durable-subscriber-name}} at all.
> However, the source code ({{VersionedStompFrameHandler.java}}) contains:
> {code}
> String durableSubscriptionName =
> frame.getHeader(Stomp.Headers.Subscribe.DURABLE_SUBSCRIBER_NAME);
> if (durableSubscriptionName == null) {
> durableSubscriptionName =
> frame.getHeader(Stomp.Headers.Subscribe.DURABLE_SUBSCRIPTION_NAME);
> }
> if (durableSubscriptionName == null) {
> durableSubscriptionName =
> frame.getHeader(Stomp.Headers.Subscribe.ACTIVEMQ_DURABLE_SUBSCRIPTION_NAME);
> }
> {code}
> In other words, if both {{durable-subscription-name}} and
> {{durable-subscriber-name}} are set, only the undocumented
> {{durable-subscriber-name}} is used.
> Why do we have {{durable-subscriber-name}} in the first place?
> If used, it should be documented. If not used, it should be removed.
> BTW, {{activemq.subscriptionName}} is also used in the code and not
> documented. But at least it does not interfere with the documented
> {{durable-subscription-name}} as it comes after...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
