[
https://issues.apache.org/jira/browse/ARTEMIS-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519768#comment-16519768
]
ASF GitHub Bot commented on ARTEMIS-1950:
-----------------------------------------
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2158
ARTEMIS-1950 clarify STOMP durable sub header names
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1950
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2158.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2158
----
commit fec327658da3bbc0616d26b59302904ca387e1b1
Author: Justin Bertram <jbertram@...>
Date: 2018-06-21T20:53:27Z
ARTEMIS-1950 clarify STOMP durable sub header names
----
> Mismatch between durable-subscriber-name and durable-subscription-name
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-1950
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1950
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Lionel Cons
> Priority: Major
>
> The STOMP documentation describes the use of {{durable-subscription-name}}
> and does not mention {{durable-subscriber-name}} at all.
> However, the source code ({{VersionedStompFrameHandler.java}}) contains:
> {code}
> String durableSubscriptionName =
> frame.getHeader(Stomp.Headers.Subscribe.DURABLE_SUBSCRIBER_NAME);
> if (durableSubscriptionName == null) {
> durableSubscriptionName =
> frame.getHeader(Stomp.Headers.Subscribe.DURABLE_SUBSCRIPTION_NAME);
> }
> if (durableSubscriptionName == null) {
> durableSubscriptionName =
> frame.getHeader(Stomp.Headers.Subscribe.ACTIVEMQ_DURABLE_SUBSCRIPTION_NAME);
> }
> {code}
> In other words, if both {{durable-subscription-name}} and
> {{durable-subscriber-name}} are set, only the undocumented
> {{durable-subscriber-name}} is used.
> Why do we have {{durable-subscriber-name}} in the first place?
> If used, it should be documented. If not used, it should be removed.
> BTW, {{activemq.subscriptionName}} is also used in the code and not
> documented. But at least it does not interfere with the documented
> {{durable-subscription-name}} as it comes after...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
