[
https://issues.apache.org/jira/browse/ARTEMIS-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554324#comment-16554324
]
ASF GitHub Bot commented on ARTEMIS-1987:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204784325
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
---
@@ -347,7 +347,7 @@ private ServerLocatorImpl(final Topology topology,
minLargeMessageSize = ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE;
- consumerWindowSize = ActiveMQClient.DEFAULT_CONSUMER_WINDOW_SIZE;
+ consumerWindowSize = -1;
--- End diff --
Should still be defaulted to a constant
> Support configuring a default consumer window size via Address Settings
> -----------------------------------------------------------------------
>
> Key: ARTEMIS-1987
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1987
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.6.2
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 2.7.0
>
>
> In ActiveMQ 5.x a very useful feature is the ability to configure a prefetch
> in a policy which then gets negotiated with an OpenWire client. This allows
> changing the default prefetch setting by destination which is important
> because different destinations will have different message types and data
> flows. It's very useful to be able to configure it on the broker so that
> each client doesn't need to configure their side and an administrator can set
> a reasonable default (where the broker is shared by multiple
> clients/customers)
> To do this in Artemis I'm proposing creating a new window size negotiation as
> part of the consumer creation. Essentially the address can be configured
> with a different default window size if desired and if the client does not
> set the window size then the new configured default will be sent to the
> client which can be used instead of the standard 1 MiB.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
