[
https://issues.apache.org/jira/browse/ARTEMIS-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554466#comment-16554466
]
ASF GitHub Bot commented on ARTEMIS-1987:
-----------------------------------------
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204819939
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
@@ -822,6 +833,20 @@ public void resetMetadata(HashMap<String, String>
metaDataToSend) {
}
}
+ @Override
+ public int getDefaultConsumerWindowSize(SimpleString address) throws
ActiveMQException {
+ if (defaultConsumerWindowSize != null) {
+ return defaultConsumerWindowSize;
+ } else if
(sessionChannel.supports(PacketImpl.SESS_CONS_WINDOW_SIZE_RESP,
getServerVersion())) {
+ Packet packet = sessionChannel.sendBlocking(new
ConsumerWindowSizeQueryMessage(address), PacketImpl.SESS_CONS_WINDOW_SIZE_RESP);
+ ConsumerWindowSizeQueryResponseMessage response =
(ConsumerWindowSizeQueryResponseMessage) packet;
--- End diff --
@michaelandrepearce - yes I could probably just extend the
SessionQueueQueryResponseMessage and create a
SessionQueueQueryResponseMessage_V4 and add that info to it...I will go ahead
and do that and rework this
> Support configuring a default consumer window size via Address Settings
> -----------------------------------------------------------------------
>
> Key: ARTEMIS-1987
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1987
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.6.2
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 2.7.0
>
>
> In ActiveMQ 5.x a very useful feature is the ability to configure a prefetch
> in a policy which then gets negotiated with an OpenWire client. This allows
> changing the default prefetch setting by destination which is important
> because different destinations will have different message types and data
> flows. It's very useful to be able to configure it on the broker so that
> each client doesn't need to configure their side and an administrator can set
> a reasonable default (where the broker is shared by multiple
> clients/customers)
> To do this in Artemis I'm proposing creating a new window size negotiation as
> part of the consumer creation. Essentially the address can be configured
> with a different default window size if desired and if the client does not
> set the window size then the new configured default will be sent to the
> client which can be used instead of the standard 1 MiB.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
