[ 
https://issues.apache.org/jira/browse/ARTEMIS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561934#comment-16561934
 ] 

ASF GitHub Bot commented on ARTEMIS-1997:
-----------------------------------------

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2200

    ARTEMIS-1997 - un-needed SimpleString creation on hotpath with Filters

    Create the SimpleString on construction of PropertyExpression so it can be 
re-used instead of creating it every time its filtered in the FilterImpl

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1997-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2200
    
----
commit 4fce78f068cc5474e43704e1fa8da2fb435b170d
Author: Michael André Pearce <michael.andre.pearce@...>
Date:   2018-07-22T03:17:50Z

    ARTEMIS-1997 - un-needed SimpleString creation on hotpath with Filters
    
    Create the SimpleString on construction of PropertyExpression so it can be 
re-used instead of creating it every time its filtered in the FilterImpl

----


> Filters cause unneeded SimpleString creation on hotpath
> -------------------------------------------------------
>
>                 Key: ARTEMIS-1997
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1997
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>            Reporter: Michael Andre Pearce
>            Assignee: Michael Andre Pearce
>            Priority: Major
>
> Currently when a filter is used, every property key needed is creating a 
> SimpleString property key, even though this static for the life of the 
> property expression.
> Creating the SimpleString at construction of the PropertyExpression would 
> remove this.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to