[
https://issues.apache.org/jira/browse/ARTEMIS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561945#comment-16561945
]
ASF GitHub Bot commented on ARTEMIS-1997:
-----------------------------------------
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2200#discussion_r206141050
--- Diff:
artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/Filterable.java
---
@@ -41,7 +43,7 @@
* @param name
* @return
*/
- Object getProperty(String name);
+ Object getProperty(SimpleString name);
--- End diff --
nice!!!
> Filters cause unneeded SimpleString creation on hotpath
> -------------------------------------------------------
>
> Key: ARTEMIS-1997
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1997
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: Michael Andre Pearce
> Assignee: Michael Andre Pearce
> Priority: Major
>
> Currently when a filter is used, every property key needed is creating a
> SimpleString property key, even though this static for the life of the
> property expression.
> Creating the SimpleString at construction of the PropertyExpression would
> remove this.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
