[
https://issues.apache.org/jira/browse/ARTEMIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642382#comment-16642382
]
ASF GitHub Bot commented on ARTEMIS-2094:
-----------------------------------------
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2351
Revert "ARTEMIS-2094 - Fix Configuration change loss when network Issue"
This reverts commit cce0e1927c258ce6f3c3c3cb0d90bad5337b7d12.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2351.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2351
----
commit 6015e24b5edf53d48c107e86bb94652327cb43a8
Author: Justin Bertram <jbertram@...>
Date: 2018-10-01T21:15:36Z
Revert "ARTEMIS-2094 - Fix Configuration change loss when network Issue"
This reverts commit cce0e1927c258ce6f3c3c3cb0d90bad5337b7d12.
----
> Configuration change loss after failover to slave
> -------------------------------------------------
>
> Key: ARTEMIS-2094
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2094
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.6.3
> Reporter: Michael Andre Pearce
> Assignee: Michael Andre Pearce
> Priority: Major
>
> This is further cases discovered during testing network failures.
> Essentially we have noticed when config settings are reloaded such as
> address-setting or security-setting, the live node correctly reloads, but
> after live failure the backup activates, the backup does not contain these
> changes due to the configuration object held inside ActiveMQServerImpl is out
> of date to when the backup server first started.
> so further enhancements/bug fixes on top of ARTEMIS-1747 - Fix Configuration
> change loss when network Issue. which fixed this for an active node.
> Essentially we just need to keep the updating of the configuration object in
> ActiveMQServerImpl outside the isActive check.
> Also address-settings and security settings should be swap'd during
> initialisation phase 2, so these are set to latest config after activation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
