[ 
https://issues.apache.org/jira/browse/ARTEMIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643764#comment-16643764
 ] 

ASF GitHub Bot commented on ARTEMIS-2094:
-----------------------------------------

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2356

    ARTEMIS-2094 Only deploy reloadable config if reloaded.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-2094-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2356
    
----
commit 42da857be1c5e526dd6d57bd1fb07e6b0bcd7d11
Author: Michael André Pearce <michael.andre.pearce@...>
Date:   2018-10-09T17:17:31Z

    ARTEMIS-2094 Only deploy reloadable config if reloaded.

----


> Configuration change loss after failover to slave
> -------------------------------------------------
>
>                 Key: ARTEMIS-2094
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2094
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.6.3
>            Reporter: Michael Andre Pearce
>            Assignee: Michael Andre Pearce
>            Priority: Major
>
> This is further cases discovered during testing network failures.
> Essentially we have noticed when config settings are reloaded such as 
> address-setting or security-setting, the live node correctly reloads, but 
> after live failure the backup activates, the backup does not contain these 
> changes due to the configuration object held inside ActiveMQServerImpl is out 
> of date to when the backup server first started.
> so further enhancements/bug fixes on top of ARTEMIS-1747 - Fix Configuration 
> change loss when network Issue. which fixed this for an active node. 
> Essentially we just need to keep the updating of the configuration object in 
> ActiveMQServerImpl outside the isActive check.
> Also address-settings and security settings should be swap'd during 
> initialisation phase 2, so these are set to latest config after activation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to