[
https://issues.apache.org/jira/browse/ARTEMIS-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667794#comment-16667794
]
ASF GitHub Bot commented on ARTEMIS-1710:
-----------------------------------------
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2401#discussion_r229110673
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -700,7 +720,7 @@ public boolean checkMemory(final Runnable
runWhenAvailable) {
@Override
public void addSize(final int size) {
- boolean globalFull = pagingManager.addSize(size).isGlobalFull();
+ boolean globalFull = !ignoreGlobalMaxSize &&
pagingManager.addSize(size).isGlobalFull();
--- End diff --
I agree: indeed it was one of my concern on it.
On one side to not impact other addresses and trigger paging due to
management messages and on the other side to maintain consistency of the
metrics related to address utilization.
Obviously just one of the paths can be chosen: I take your point and I
agree to maintain correct metrics instead :+1:
> Allow for management messages to pass the global-max-size limit
> ---------------------------------------------------------------
>
> Key: ARTEMIS-1710
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1710
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Ulf Lilleengen
> Assignee: Francesco Nigro
> Priority: Major
>
> Use case: global-max-size is set to some limit to prevent the broker from
> falling over. The broker is configured with N queues which are all blocked by
> this limit.
> If this limit is reached, however, it is not possible to perform management
> operations on the broker, so you're stuck.
>
> It should be possible to have an address like 'activemq.management' bypass
> this limit so that a broker can be recovered when the global-max-size is
> reached.
>
> To work around the problem, an external component needs to ensure that all
> addresses created have a max-size-bytes set so that worst case, there is some
> room left for 'activemq.management' address. In this case the broker
> configuration needs to be known by the component creating addresses which is
> impractical and it feels like this problem would be easier to solve inside
> the broker.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
