[
https://issues.apache.org/jira/browse/ARTEMIS-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674130#comment-16674130
]
ASF GitHub Bot commented on ARTEMIS-1710:
-----------------------------------------
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2414
ARTEMIS-1710 Allow management msgs to exceed global-max-size limit
This is an alternative version of
https://github.com/apache/activemq-artemis/pull/2401 that:
- disable paging on management addresses
- take care to avoid NPE on any uses of a management address `PagingStore`
- management messages are not counted on `PagingManager::getGlobalSize`
(given that no `PagingStore` exists for a management address)
- take care to adjust addresses metrics on a management address
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-1710_1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2414.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2414
----
commit fa715d9c4e49ee66bf367b81b513e21f79c75b93
Author: Francesco Nigro <nigro.fra@...>
Date: 2018-11-03T15:37:26Z
ARTEMIS-1710 Allow management msgs to exceed global-max-size limit
----
> Allow for management messages to exceed global-max-size limit
> -------------------------------------------------------------
>
> Key: ARTEMIS-1710
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1710
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Ulf Lilleengen
> Assignee: Francesco Nigro
> Priority: Major
>
> Use case: global-max-size is set to some limit to prevent the broker from
> falling over. The broker is configured with N queues which are all blocked by
> this limit.
> If this limit is reached, however, it is not possible to perform management
> operations on the broker, so you're stuck.
>
> It should be possible to have an address like 'activemq.management' bypass
> this limit so that a broker can be recovered when the global-max-size is
> reached.
>
> To work around the problem, an external component needs to ensure that all
> addresses created have a max-size-bytes set so that worst case, there is some
> room left for 'activemq.management' address. In this case the broker
> configuration needs to be known by the component creating addresses which is
> impractical and it feels like this problem would be easier to solve inside
> the broker.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
